Tests: Don't touch stdin.buffer
#3041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces `println(stdin.buffer, ...)` with a `redirect_stdin` approach.
|
Thanks for fixing this! |
vtjnash
reviewed
Mar 24, 2022
|
BufferStream should also work, but requires using the internal |
|
Thanks! The internal function does not take care about replacing the original |
|
Seems good to me. Thanks! |
KristofferC
pushed a commit
that referenced
this pull request
May 24, 2022
Co-authored-by: Jameson Nash <vtjnash@gmail.com> (cherry picked from commit a23a4d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
println(stdin.buffer, ...)with aredirect_stdinapproach.@vtjnash Could you check the
stdinredirection? I couldn't make it work withBase.BufferStream.Fixes #2961