Improve inference for paths leading to similar
#1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this will require some of my unmerged work on BitArray inference and API, so obviously hold off on merging this. |
|
Too hasty, that commit hadn't hit nightly yet. Should be OK tomorrow. |
|
#1984 made a merge conflict with this, sorry. |
|
No worries. |
timholy
force-pushed
the
teh/similar_inference
branch
from
d17b5d6
to
73629ad
Compare
Pkg doesn't really use multidimensional arrays, and the extra info about dimensionality allows better inference for output array allocation.
Inference struggles a bit with the original implementations, but the new ones work successfully.
timholy
force-pushed
the
teh/similar_inference
branch
from
73629ad
to
238d523
Compare
|
Given @staticfloat's upcoming Artifacts stdlib, should I modify this in any way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The companion PR to JuliaLang/julia#37163
The message in the first commit mentions this, but perhaps worth repeating: using
Vectorrather thanArrayin certain places allows inference to know thatsize(A)is aTuple{Int}, and that ends up fixing some otherwise hard-to-solve problems in inference with thesimilarpipeline.