Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryPlatforms: Recognize MacOS(:aarch64) #1916

Merged
merged 1 commit into from
Jul 11, 2020
Merged

BinaryPlatforms: Recognize MacOS(:aarch64) #1916

merged 1 commit into from
Jul 11, 2020

Conversation

Keno
Copy link
Member

@Keno Keno commented Jul 9, 2020

@Keno Keno requested a review from staticfloat July 9, 2020 19:21
@Keno Keno merged commit 3eee6eb into master Jul 11, 2020
@Keno Keno deleted the kf/applearm64 branch July 11, 2020 02:50
@giordano
Copy link
Contributor

MacOS() still defaults to x86_64, kept for backward compatibility I guess?

@staticfloat
Copy link
Member

Yes, it's going to be a while before that's changed, I think. :P

@giordano
Copy link
Contributor

giordano commented Jul 12, 2020

Sure, I was not thinking about changing the default, but rather about the fact other platforms with multiple possible architectures, like Linux and Windows, don't have a default constructor without the specification of the architecture. I assume removing the MacOS() method would be breaking though.

@staticfloat
Copy link
Member

Indeed; hindsight is 20:20.

That being said, if we think it would be better, I have no qualms about breaking build_tarballs.jl files. It's a very easy fix, and Yggdrasil contains a high percentage of what we care about.

fredrikekre pushed a commit that referenced this pull request Sep 5, 2020
Also normalize arm64 -> aarch64, c.f.
https://lists.gnu.org/archive/html/config-patches/2020-07/msg00002.html

(cherry-picked from commit 3eee6eb, PR #1916)

Co-authored-by: Keno Fischer <keno@juliacomputing.com>
Co-authored-by: Elliot Saba <staticfloat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants