Enable Travis and Appveyor #1400
Conversation
| - master | ||
| - staging | ||
| - trying | ||
| - /^v[0-9]+\.[0-9]+\.[0-9]+$/ # version tags |
There was a problem hiding this comment.
If we keep these, that means there will be no CI run on pull requests.
There was a problem hiding this comment.
I think these are only for branch pushes, not PRs.
| only: | ||
| - staging | ||
| - trying | ||
| - /^v[0-9]+\.[0-9]+\.[0-9]+$/ # version tags |
There was a problem hiding this comment.
If we keep this, that means there will be no CI run on pull requests.
There was a problem hiding this comment.
I think those are only for branch pushes,not PRs.
There was a problem hiding this comment.
So according to #1401 it looks like it's half-true; we don't get the build of the tip of the PR branch (Which I think is valuable, it helps to debug bad interactions and general flakiness) so perhaps what we should do is to add /^refs/pull/.*/ or something, so that we get both, but we don't get pushes of branches that don't have a PR open, to keep the number of unnecessary CI runs down?
staticfloat
force-pushed
the
sf/enable_travis_appveyor
branch
from
95517ef to
a647b73
Compare
Codecov Report
@@ Coverage Diff @@
## master #1400 +/- ##
==========================================
+ Coverage 87.51% 87.61% +0.09%
==========================================
Files 25 25
Lines 5335 5335
==========================================
+ Hits 4669 4674 +5
+ Misses 666 661 -5
Continue to review full report at Codecov.
|
staticfloat
force-pushed
the
sf/enable_travis_appveyor
branch
from
a647b73 to
42d7d83
Compare
staticfloat
force-pushed
the
sf/enable_travis_appveyor
branch
from
42d7d83 to
25e2265
Compare
|
Merging this as well, to get CI working again. |
3 participants
No description provided.