Make the link to the Pkg docs more searchable #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Sep 12, 2019
Member
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 12, 2019
1380: Make the link to the Pkg docs more searchable r=KristofferC a=ChrisRackauckas If you try and search the Julia documentation for Project.toml, you only get https://docs.julialang.org/en/v1/manual/code-loading/#Project-environments-1 . If you search compat, you get https://docs.julialang.org/en/v1/search/?q=compat , which is really just showing results like https://docs.julialang.org/en/v1/manual/calling-c-and-fortran-code/#Creating-C-Compatible-Julia-Function-Pointers-1 . This makes it very difficult to find out where to learn about Pkg. Thus I threw a bunch of keywords in there to make the search mechanism lead people to this link. Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>
Member
|
Squash? |
Member
|
bors r- |
Contributor
Canceled |
Member
|
Yeah, needs to be squashed. |
Member
Author
|
Saying you want me to squash or are you going to do a squash merge? |
fredrikekre
force-pushed
the
patch-5
branch
from
ccae3e2 to
75d148d
Compare
Member
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 12, 2019
1380: Make the link to the Pkg docs more searchable r=fredrikekre a=ChrisRackauckas If you try and search the Julia documentation for Project.toml, you only get https://docs.julialang.org/en/v1/manual/code-loading/#Project-environments-1 . If you search compat, you get https://docs.julialang.org/en/v1/search/?q=compat , which is really just showing results like https://docs.julialang.org/en/v1/manual/calling-c-and-fortran-code/#Creating-C-Compatible-Julia-Function-Pointers-1 . This makes it very difficult to find out where to learn about Pkg. Thus I threw a bunch of keywords in there to make the search mechanism lead people to this link. Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try and search the Julia documentation for Project.toml, you only get https://docs.julialang.org/en/v1/manual/code-loading/#Project-environments-1 . If you search compat, you get https://docs.julialang.org/en/v1/search/?q=compat , which is really just showing results like https://docs.julialang.org/en/v1/manual/calling-c-and-fortran-code/#Creating-C-Compatible-Julia-Function-Pointers-1 . This makes it very difficult to find out where to learn about Pkg. Thus I threw a bunch of keywords in there to make the search mechanism lead people to this link.