- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 197
          macOS: If using Xcode CLT >= 15, add -Wl,-ld_classic in create_sysimg_from_object_file()
          #972
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
f55b24e    to
    22a135b      
    Compare
  
    | 
 Okay, #935 (comment) is now addressed by the combination of c9a4b52 and adf5737. | 
| Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
- Coverage   84.56%   83.00%   -1.57%     
==========================================
  Files           3        4       +1     
  Lines         823      859      +36     
==========================================
+ Hits          696      713      +17     
- Misses        127      146      +19     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| Okay, #935 (comment) is now addressed by the combination of c9a4b52 and adf5737. | 
| Specifically, we now run  | 
| Thanks for putting this together @DilumAluthge! | 
| @jayscook Thank you for putting the original PR together (and thank you to @PhilReinhold for writing the original code). | 
| @topolarity Could you take a look at this PR, and let me know if it addresses your concerns in #935 (comment) and #935 (comment)? | 
| Sure thing! Looks like the right direction, but I won't be able to take a close look until Monday | 
| Sounds good, thanks man! | 
-Wl,-ld_classic for Xcode CLT >= 15-Wl,-ld_classic in create_sysimg_from_object_file()
      257d751    to
    10f4386      
    Compare
  
    Co-authored-by: Jay Cook <john.cook@betterment.com> Co-authored-by: Phil Reinhold <pcreinhold@gmail.com>
Co-authored-by: Jay Cook <john.cook@betterment.com> Co-authored-by: Phil Reinhold <pcreinhold@gmail.com>
Co-authored-by: Jay Cook <john.cook@betterment.com> Co-authored-by: Phil Reinhold <pcreinhold@gmail.com>
10f4386    to
    f387dbb      
    Compare
  
    
Replaces #935 (closes #935)
Reference #738
This is based on #935. All credit goes to @PhilReinhold for providing the fix and @jayscook for opening the original PR (#935).
This PR differs slightly from #935. #935 used a try-catch. This PR uses
ignorestatus()to ignore non-zero exit codes from running the$cc --versioncommand, and usesisnothing()to handle the case where the regex does not match. Also, this PR factors out the "detect CLT major version" functionality out into a separate helper function.Also, this PR now addresses #935 (comment)
We do not add these flags for CLT versions <= 14.