Skip to content

Fix overflow and type issues with generic det of a triangular matrix #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 15, 2025
Merged

Fix overflow and type issues with generic det of a triangular matrix #1418

merged 11 commits into from
Aug 15, 2025

Conversation

lxvm
Copy link
Contributor

@lxvm lxvm commented Aug 14, 2025

Fixes #1415

lxvm added 8 commits August 14, 2025 11:22
@lxvm
Update generic.jl
04bcd19
@lxvm
Create SimpleUnit.jl
c74faa1
@lxvm
Update Furlongs.jl
62d9ca3 
add rtoldefault for isapprox comparisons
@lxvm
Update generic.jl
5cd6af2 
add test for generic triangular det to check no overflow and unitful matrices
@lxvm
Update Furlongs.jl
5cf31ac 
removed un-needed modification
@lxvm
Delete test/testhelpers/SimpleUnit.jl
53d36c5
@lxvm
Update generic.jl
321c710 
fix typo
@lxvm
Update generic.jl
29155d4 
use `convert` as a more generic constructor
@lxvm
Copy link
Contributor Author

lxvm commented Aug 14, 2025

Instead of using the number type as a constructor, I switched back to using convert because this fixed some broken tests for minimal number types that did not define the constructor. I used Base.Fix(convert, S) rather than y -> convert(S, y) because the latter is not type stable.

@lxvm lxvm changed the title Fix type issues with generic det of a triangular matrix Fix overflow and type issues with generic det of a triangular matrix Aug 14, 2025
stevengj
stevengj reviewed Aug 14, 2025
View reviewed changes
stevengj
stevengj reviewed Aug 14, 2025
View reviewed changes
lxvm and others added 2 commits August 14, 2025 14:16
@lxvm @stevengj
Update test/generic.jl
93f7b30 
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
@lxvm
Update generic.jl
b8006e3 
fix 0-d case
@stevengj stevengj added backport 1.11 Change should be backported to the 1.11 release backport 1.10 Change should be backported to the 1.10 release backport 1.12 Change should be backported to release-1.12 labels Aug 14, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.87%. Comparing base (6c92d28) to head (58d5115).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
- Coverage   93.90%   93.87%   -0.04%     
==========================================
  Files          34       34              
  Lines       15851    15851              
==========================================
- Hits        14885    14880       -5     
- Misses        966      971       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lxvm @stevengj
Update test/generic.jl
58d5115 
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
@stevengj
Copy link
Member

The codecov failure seems spurious.

@stevengj stevengj merged commit 5a55cc8 into JuliaLang:master Aug 15, 2025
3 of 4 checks passed
@lxvm lxvm deleted the lxvm-patch-1 branch August 15, 2025 14:50
dkarrasch pushed a commit that referenced this pull request Aug 18, 2025
@lxvm @stevengj @dkarrasch
Fix overflow and type issues with generic det of a triangular matrix (#…
49f91e2 
…1418)

Fixes #1415

---------

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
@dkarrasch dkarrasch mentioned this pull request Aug 18, 2025
Merged
dkarrasch pushed a commit that referenced this pull request Aug 18, 2025
@lxvm @stevengj @dkarrasch
Fix overflow and type issues with generic det of a triangular matrix (#…
bd88dc9 
…1418)

Fixes #1415

---------

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
dkarrasch pushed a commit that referenced this pull request Aug 18, 2025
@lxvm @stevengj @dkarrasch
Fix overflow and type issues with generic det of a triangular matrix (#…
fb7bee4 
…1418)

Fixes #1415

---------

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
ViralBShah added a commit that referenced this pull request Aug 19, 2025
@ViralBShah
Backports release 1.12 (#1411)
ad868c7 
[x] #1365
[x] #1373 
[x] #1385 
[x] #1397 
[x] #1402 
[x] #1413 
[x] #1417 
[x] #1418
@dkarrasch dkarrasch removed the backport 1.12 Change should be backported to release-1.12 label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to the 1.11 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DimensionError for determinant of generic, triangular, unitful matrices
3 participants
@lxvm @stevengj @dkarrasch