sftp protocol status in case of no error is 0 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 5 5
Lines 518 518
=======================================
Hits 479 479
Misses 39 39
Continue to review full report at Codecov.
|
|
Thanks! |
|
Should be backported, right? |
|
Sure, it's a bugfix, but we could also just say that supporting SFTP is a new feature, so 🤷🏻♂️ |
Merged
StefanKarpinski
pushed a commit
that referenced
this pull request
Mar 24, 2022
see https://curl.se/libcurl/c/sftpget.html see discussion https://discourse.julialang.org/t/how-to-use-downloads-download-with-sftp/76480 (cherry picked from commit 959a9a1)
StefanKarpinski
pushed a commit
that referenced
this pull request
Mar 24, 2022
see https://curl.se/libcurl/c/sftpget.html see discussion https://discourse.julialang.org/t/how-to-use-downloads-download-with-sftp/76480 (cherry picked from commit 959a9a1)
Merged
|
It's unclear to me which version(s) of Downloads.jl this patch is included in, and similarly which version(s) of Julia this patch is included in. Can someone please clarify? Many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://curl.se/libcurl/c/sftpget.html
see discussion https://discourse.julialang.org/t/how-to-use-downloads-download-with-sftp/76480