Fix current_exceptions when called with backtrace=false (#757). #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
==========================================
- Coverage 78.41% 78.35% -0.06%
==========================================
Files 4 4
Lines 630 633 +3
==========================================
+ Hits 494 496 +2
- Misses 136 137 +1
Continue to review full report at Codecov.
|
Sacha0
force-pushed
the
sv-fix-curr-exc
branch
from
2f4df48 to
2e82b75
Compare
which bears a backtrace keyword argument. When backtrace=false,
the returned ExceptionStack's stack field should be a Vector of
NamedTuples where the second (backtrace) element of each tuple is
nothing. Instead the Compat implementation throws,
e.g. on Julia 1.6.2:
julia> using Compat: current_exceptions
julia> try
throw(UndefVarError(:cat))
catch
current_exceptions(;backtrace=false)
end
ERROR: MethodError: no method matching getindex(::UndefVarError, ::Int64)
Stacktrace:
[1] current_exceptions(task::Task; backtrace::Bool)
@ Compat ~/pkg/Compat.jl/src/Compat.jl:1105
[2] top-level scope
@ REPL[7]:4
caused by: UndefVarError: cat not defined
Stacktrace:
[1] top-level scope
@ REPL[7]:2
The trick is that the implementation
function current_exceptions(task=current_task(); backtrace=true)
stack = Base.catch_stack(task, include_bt=backtrace)
ExceptionStack(Any[(exception=x[1],backtrace=x[2]) for x in stack])
end
passes the backtrace kwarg through to catch_stack which,
when include_bt=false, emits a Vector of exceptions, rather than
a Vector of two-tuples (exception-backtrace pairs). The array
comprehension on the next line expects a Vector of two-tuples, though,
and consequently ends up attempting to index into exceptions.
This commit constructs the ExceptionStack-wrapped stack Vector
appropropriately for backtrace=false, and strengthens the tests
to cover that case.
Sacha0
force-pushed
the
sv-fix-curr-exc
branch
from
2e82b75 to
ad62e78
Compare
|
Thanks for reviewing Chris! I hope you're doing well! :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #757, which contains a description of the issue, and strengthens associated tests. Best! :)