Skip to content

Conversation

@tkf
Copy link
Member

@tkf tkf commented Apr 22, 2020

Quoting README:

  • mergewith(combine, dicts...) and mergewith!(combine, dicts...) are like merge(combine, dicts...) and merge!(combine, dicts...) but without the restriction that the argument combine must be a Function ([#34296]). (since Compat 3.9.0).

Ref: JuliaLang/julia#34296

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine.

tkf and others added 3 commits April 27, 2020 14:40
@tkf
Copy link
Member Author

tkf commented Apr 27, 2020

@martinholters Thanks for the review! I updated the patch.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Will merge soon unless someone objects or beats me to it.

@martinholters martinholters merged commit af45b90 into JuliaLang:master Apr 29, 2020
@tkf tkf deleted the mergewith branch April 29, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants