-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added eachrow/col/slice for v1.0 #658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I support dropping support for 0.6, we still do support it and run CI on it, so we should also keep the tests passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little issue with the test version bound and a suggestion regarding the README entry, otherwise LGTM.
Co-Authored-By: Martin Holters <martin.holters@hsu-hh.de>
Co-Authored-By: Martin Holters <martin.holters@hsu-hh.de>
Let's get the ball going for #639.
This won't work at all for 0.6 from what I saw on JuliaBox, too many things missing (
axes
,OneTo
...). 0.6 support is getting dropped though, right?Also, I don't know how to get the exact version where these were defined. It was this PR JuliaLang/julia#29749