Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Project.toml file #624

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Remove Project.toml file #624

merged 1 commit into from
Aug 27, 2018

Conversation

andreasnoack
Copy link
Member

since it not needed yet and causes problems for our reverse dependency testing.

It can be added again easily when it is needed or CIBot has been upgraded.

@andreasnoack andreasnoack changed the title Remote Project.toml file Remove Project.toml file Aug 23, 2018
Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, at the moment, having a Project.toml seems to do more harm than good. I'm tempted to propose waiting with adding it back until we have tooling for releases that ensures the version is updated correctly.

@@ -1,27 +0,0 @@
name = "Compat"
uuid = "34da2185-b29b-5c13-b0c7-acf172513d20"
version = "v1.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone had tagged a new version without bumping this, which (I think) was the reason I had a problem pkg> deving this. Might the problems with CIBot be related to that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone had tagged a new version without bumping this, which (I think) was the reason I had a problem pkg> deving this

Likely, although a wrong version there is usually no more than a display problem

Might the problems with CIBot be related to that?

No, apparently CIBot uses the old package manager and thats why.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is usually no more than a display problem

With dev/Compat checked out to v1.0.1:

julia> VERSION
v"1.1.0-DEV.72"

(pkgtest) pkg> st
    Status `/tmp/pkgtest/Project.toml`

(pkgtest) pkg> dev Compat
  Updating git-repo `https://github.com/JuliaLang/Compat.jl.git`
┌ Warning: project file for Compat at /tmp/tmp0jlHBR is missing a `version` entry
└ @ Pkg.Types stdlib/v1.1/Pkg/src/Types.jl:700
[ Info: Path `/home/hol/.julia/dev/Compat` exists and looks like the correct package, using existing path instead of cloning
 Resolving package versions...
ERROR: Unsatisfiable requirements detected for package Compat [34da2185]:
 Compat [34da2185] log:
 ├─possible versions are: 1.0.0 or uninstalled
 ├─Compat [34da2185] is fixed to version 1.0.0
 └─restricted to versions 1.0.1 by an explicit requirement — no versions left

(pkgtest) pkg> st
    Status `/tmp/pkgtest/Project.toml`

julia> using Compat
ERROR: ArgumentError: Package Compat not found in current path:
- Run `import Pkg; Pkg.add("Compat")` to install the Compat package.

If I fix the version in Project.toml, it works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so maybe some package have a requirement on Compat 1.0.1?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, I'm doing this within an empty environment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I file an issue at Pkg.jl?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should try with master of Pkg first which have fixed a number of bugs (JuliaLang/julia#28822)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, works with JuliaLang/julia#28822.

@martinholters
Copy link
Member

CC @KristofferC, @StefanKarpinski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants