Skip to content

Commit

Permalink
Mark Compat.LinearAlgebra from #463 for deprecation
Browse files Browse the repository at this point in the history
  • Loading branch information
martinholters committed Oct 8, 2019
1 parent b95638c commit 3620451
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 14 deletions.
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ Currently, the `@compat` macro supports the following syntaxes:
* `using Compat.SparseArrays` is provided on versions older than 0.7, where this library is
not yet part of the standard library ([#25249]).

* `using Compat.LinearAlgebra` is provided on versions older than 0.7, where this library is
not yet part of the standard library ([#25571]).

* `using Compat.Random` is provided on versions older than 0.7, where this library is
not yet part of the standard library ([#24874]).

Expand Down
7 changes: 1 addition & 6 deletions src/Compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,11 @@ import Dates
import Libdl
const AbstractDateTime = Compat.Dates.AbstractDateTime
import Printf
import LinearAlgebra


include("compatmacro.jl")

@static if VERSION < v"0.7.0-DEV.3449"
const LinearAlgebra = Base.LinAlg
else
import LinearAlgebra
end

if VERSION < v"0.7.0-DEV.3389"
const SparseArrays = Base.SparseArrays
else
Expand Down
5 changes: 5 additions & 0 deletions test/old.jl
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ module Test25056
@test isdefined(@__MODULE__, Symbol("@sprintf"))
end

# 0.7.0-DEV.3449
let A = [2.0 1.0; 1.0 3.0], b = [2.0, 3.0]
@test diag(A) == b
end


# tests of removed functionality (i.e. justs tests Base)

Expand Down
5 changes: 0 additions & 5 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -249,11 +249,6 @@ end
# 0.7.0-DEV.912
@test occursin('W', "Hello, World!")

# 0.7.0-DEV.3449
let A = [2.0 1.0; 1.0 3.0], b = [2.0, 3.0]
@test diag(A) == b
end

# 0.7.0-DEV.3173
@test invpermute!(permute!([1, 2], 2:-1:1), 2:-1:1) == [1, 2]

Expand Down

0 comments on commit 3620451

Please sign in to comment.