Mark Compat.Libdl from #465 (and #467) for deprecation

JuliaLang · Oct 1, 2019 · 1f65e80 · 1f65e80
1 parent 09b8dd9
commit 1f65e80
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -70,9 +70,6 @@ Currently, the `@compat` macro supports the following syntaxes:
 * `using Compat.Random` is provided on versions older than 0.7, where this library is
   not yet part of the standard library ([#24874]).
 
-* `using Compat.Libdl` is provided on versions older than 0.7, where this library is
-  not yet part of the standard library ([#25459]).
-
 * `using Compat.REPL` is provided on versions older than 0.7, where this library is
   not yet part of the standard library ([#25544]).
 

diff --git a/src/Compat.jl b/src/Compat.jl
@@ -21,16 +21,11 @@ end
 import Base.MathConstants
 import Test, SharedArrays, Mmap, DelimitedFiles
 import Dates
+import Libdl
 
 
 include("compatmacro.jl")
 
-if VERSION < v"0.7.0-DEV.3382"
-    const Libdl = Base.Libdl
-else
-    import Libdl
-end
-
 # https://github.com/JuliaLang/julia/pull/24182
 if VERSION < v"0.7.0-DEV.2402"
     const ConvertiblePeriod = Union{Compat.Dates.TimePeriod, Compat.Dates.Week, Compat.Dates.Day}

diff --git a/test/old.jl b/test/old.jl
@@ -94,6 +94,14 @@ module Test24459
     @test isdefined(@__MODULE__, :Dates)
 end
 
+# 0.7.0-DEV.3382
+module TestLibdl
+    using Compat
+    using Compat.Libdl
+    using Compat.Test
+    @test isdefined(@__MODULE__, :Libdl)
+end
+
 
 # tests of removed functionality (i.e. justs tests Base)
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -412,14 +412,6 @@ end
 @test nameof(Float64) == :Float64
 @test nameof(Array) == :Array
 
-# 0.7.0-DEV.3382
-module TestLibdl
-    using Compat
-    using Compat.Libdl
-    using Compat.Test
-    @test isdefined(@__MODULE__, :Libdl)
-end
-
 # 0.7.0-DEV.3516
 @test argmax([10,12,9,11]) == 2
 @test argmax([10 12; 9 11]) == CartesianIndex(1, 2)