Skip to content

Min and max docstrings #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Conversation

mforets
Copy link
Contributor

@mforets mforets commented Jul 10, 2019

This PR attaches the existing docstring to minimise, so it is visible by doing ?minimise in the REPL, and adds a new one to maximise.

@codecov-io
Copy link

codecov-io commented Jul 10, 2019

Codecov Report

Merging #38 into master will increase coverage by 18.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #38       +/-   ##
===========================================
+ Coverage    67.9%   85.93%   +18.03%     
===========================================
  Files           4        4               
  Lines          81       64       -17     
===========================================
  Hits           55       55               
+ Misses         26        9       -17
Impacted Files Coverage Δ
src/optimise.jl 83.33% <ø> (+15.15%) ⬆️
src/SortedVectors.jl 66.66% <0%> (+9.52%) ⬆️
src/HeapedVectors.jl 96.96% <0%> (+24.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09b52a4...f3eb757. Read the comment docs.

@dpsanders
Copy link
Member

LGTM, thanks!

@dpsanders dpsanders merged commit f28247f into JuliaIntervals:master Jul 10, 2019
@mforets mforets deleted the mforets/maximise branch July 10, 2019 20:29
mforets added a commit to mforets/IntervalOptimisation.jl that referenced this pull request Jul 10, 2019
min and max docstrings (JuliaIntervals#38)
add tests for maximise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants