Rewrite the package to use Symbolics and ReversePropagation #212
Conversation
dpsanders
changed the title
|
Is there a reason to un-support versions below v1.10? That makes this package harder to use downstream when running tests on older versions, so one may have to write version-specific wrapper code. |
|
The reason is just that I don't know which previous versions will work with this combination. I can change it back. |
| julia = "1.3" | ||
| IntervalArithmetic = "0.22.12" | ||
| IntervalContractors = "0.5" | ||
| ReversePropagation = "0.3" | ||
| Symbolics = "5, 6" | ||
| julia = "1" |
There was a problem hiding this comment.
Symbolics v5 already required Julia v1.6, so widening the lower bound from v1.3 to v1.0 seems strange. Maybe you intended to use a higher version?
There was a problem hiding this comment.
Won't that get resolved automatically?
There was a problem hiding this comment.
True, just tried it:
(v1.1) pkg> add IntervalConstraintProgramming
[...]
Installed IntervalConstraintProgramming ─ v0.12.0
[...]But I still find it misleading when you look at the Project file to know which version you need at least. Then I would rather omit the julia entry completely.
| - '1.3' # oldest Julia version that works | ||
| - '1.8' # newest Julia version that works with ModelingToolkit | ||
| - '1' | ||
| - '1.10' |
There was a problem hiding this comment.
I would not recommend removing the tests on older Julia versions and only testing on v1.10. It is very easy to introduce changes that break old versions unnoticed (I saw it happening many times), particularly because you presumably do not use them for development anymore. If v1.10 is the lowest supported version, that should be reflected in Project.toml (see the other comment).
There was a problem hiding this comment.
I'm inclined to just set the lower bound as 1.10 since that's the new LTS version, right?
There was a problem hiding this comment.
Totally reasonable.
But note that v1.6-v1.9 would still be installing the current release. So if it broke, that would leave the package in a broken state for these Julia versions. (You could retroactively fix the entry in the registry to raise the Julia version in that case.)
Update #204 to work with Symbolics 5, IntervalArithmetic 0.22.