Make Socket hold a reference to its Context #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the `Context` from being garbage collected while the `Socket` is still alive, otherwise the `Socket` would be closed by the `Context`'s finalizer while the `Socket` is potentially still in use.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
=======================================
Coverage 78.17% 78.17%
=======================================
Files 9 9
Lines 362 362
=======================================
Hits 283 283
Misses 79 79 ☔ View full report in Codecov by Sentry. |
|
(if there's no objections, I'd like to merge this by the end of the week) |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the
Contextfrom being garbage collected while theSocketis still alive, otherwise theSocketwould be closed by theContext's finalizer while theSocketis potentially still in use.Fixes #223. The problem is Julia thinking it could delete the
Contextin spite of theSocketactually needing it. In the function the compiler was probably able to prove it could be GC'd, which is why it was failing in the function but not in the script/REPL.