update tests, fix setindex! on message

[ggggggggg]

I fixed setindex!, and wrote some tests for it. I updated the tests to use @test, @testset, and @test_throws. I think the previous test was trying to show that closing a socket twice throws an error, but it doesn't and the previous test missed that.

[ggggggggg]

It's failing on Julia 0.4. I could require BaseTestNext. Or, like HDF5.jl (the only package I'm subscribed to), we could let ZMQ stop testing on 0.4. Preference?

[tkelman]

Probably fine to drop 0.4 support, but should be done in REQUIRE too, not just in the travis matrix.

[ggggggggg]

ci passing

[ggggggggg]

I rebased this pr on master. It fixes setindex!, tests it. It also replaces an ineffective test for a repeat ZMQ.close(s) test with @test_broken so it is clear that it is broken. Please give me some feedback before it goes out of date again.

I don't think the nightly failure has anything to do with this.

[ggggggggg]

bump? Sorry to keep pinging, but I'm overwriting the broken setindex! method in one of my packages, which means I get WARNINGs that I can't fix without merging this.

[ggggggggg]

thanks!

…

On Sat, Apr 7, 2018 at 8:03 PM, Steven G. Johnson ***@***.***> wrote: Closed #141 <#141> via #174 <#174>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE87gdbBuCfhMBd-l-H1NZcX4TV8b0HHks5tmW_xgaJpZM4M8R_C> .