Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JNIVector garbage collection, check if JVM destroyed #163

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented Mar 21, 2022

Fixes:

  1. Explicitly set own = false with unsafe_wrap since Java should free the array, not Julia
  2. Make sure the JVM has not been destroyed before we to call Release*

cc: @ahnlabb

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@96353a4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #163   +/-   ##
=========================================
  Coverage          ?   64.43%           
=========================================
  Files             ?       10           
  Lines             ?      984           
  Branches          ?        0           
=========================================
  Hits              ?      634           
  Misses            ?      350           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96353a4...5cbc6c3. Read the comment docs.

@mkitti
Copy link
Member Author

mkitti commented Mar 21, 2022

The JNI module should be fixed so that one can just pass the array rather than explicitly having to extract the pointer via pointer.

@mkitti mkitti merged commit 880188d into master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants