-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade source-build to BB2 for Julia 1.3 #450
Conversation
I will give it a try, what are the chances that we could merge the changes from #425 as well? |
LLVMBuilder at v6.0.1-7+nowasm
LLVM/Clang binaries from BB2 can be reused, but we do need to download and patch LLVM/Clang's source code for building libcxxffi.
@MaximeBouton I'm going to rebase #425 on the current master branch and release new libcxxffi binaries for Julia 1.3. Source-build for Windows is out of the scope of this PR. |
There are CI failures related to the location of
|
It happens for me too on 1.3 |
Now, we don't need to compile LLVM/Clang locally when building Julia, it feels insane to turn off
USE_BINARYBUILDER
and wait for 1h+ to use Cxx.jl. This PR upgrades BuildBootstrap.Makefile to reuse LLVM/Clang binaries from LLVMBuilder. With this PR, building Cxx.jl itself only takes <5min on my machine. :PBTW, #407 and #434 are also merged into this PR for testing. To test this PR, simply building Julia release-1.3 from source(DO NOT set
USE_BINARYBUILDER=0
) and dev, checkout, build Cxx in REPL.close #435, close #437, close #441
cc @musm @goretkin @oschulz @christianpeel @GlenHenshaw @MaximeBouton