-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sujoy edge demo #158
sujoy edge demo #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some comments to make it a better demo.
Also, could you move the file to docs/examples/contours
folder? It doesn't look good to me to have a separate section for this demo.
The result actually looks quite good to me so I personally think it's good to get this in. But I'd like to get @zygmuntszpak involved here to see if he has some other comments.
I think Johnny has made some excellent suggestions. A further small detail: edges = sujoy(img, kernel_nhood=0, just_filter=False) Change Also, since kernel_nhood : 0(default) or 1 have something along the lines of four_connectivity : true (default) or false (uses 8-connectivity instead) |
Hi |
* For consistent results, only use ImageMagick * add ImageBinarization
I've made some changes based on your codes, hope that's okay with you. |
Hi
I added the sujoy edge demo. I checked locally It was working as expected. Kindly accept it.