Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sujoy edge demo #158

Merged
merged 5 commits into from
Sep 24, 2020
Merged

sujoy edge demo #158

merged 5 commits into from
Sep 24, 2020

Conversation

amarbit
Copy link
Contributor

@amarbit amarbit commented Sep 20, 2020

Hi
I added the sujoy edge demo. I checked locally It was working as expected. Kindly accept it.

@johnnychen94 johnnychen94 mentioned this pull request Sep 20, 2020
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some comments to make it a better demo.

Also, could you move the file to docs/examples/contours folder? It doesn't look good to me to have a separate section for this demo.

The result actually looks quite good to me so I personally think it's good to get this in. But I'd like to get @zygmuntszpak involved here to see if he has some other comments.

docs/examples/sujoy_edge/sujoy_edge_demo.jl Outdated Show resolved Hide resolved
docs/examples/sujoy_edge/sujoy_edge_demo.jl Outdated Show resolved Hide resolved
docs/examples/sujoy_edge/sujoy_edge_demo.jl Outdated Show resolved Hide resolved
docs/examples/sujoy_edge/sujoy_edge_demo.jl Outdated Show resolved Hide resolved
docs/examples/sujoy_edge/sujoy_edge_demo.jl Outdated Show resolved Hide resolved
docs/examples/sujoy_edge/sujoy_edge_demo.jl Outdated Show resolved Hide resolved
docs/examples/sujoy_edge/sujoy_edge_demo.jl Outdated Show resolved Hide resolved
@zygmuntszpak
Copy link
Member

I think Johnny has made some excellent suggestions. A further small detail:

edges = sujoy(img, kernel_nhood=0, just_filter=False)

Change False to false.

Also, since kernel_nhood toggles between a 4 or 8 connected neighbourhood, perhaps it is better to switch to a Bool type and instead of

kernel_nhood : 0(default) or 1

have something along the lines of

four_connectivity : true (default) or false (uses 8-connectivity instead)

@amarbit
Copy link
Contributor Author

amarbit commented Sep 24, 2020

Hi
did all changes as you suggested. Please accept it.

* For consistent results, only use ImageMagick
* add ImageBinarization
@johnnychen94 johnnychen94 merged commit 84e7b2d into JuliaImages:source Sep 24, 2020
@johnnychen94
Copy link
Member

I've made some changes based on your codes, hope that's okay with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants