Skip to content

improve the parse_corners_file function#55

Merged
timholy merged 1 commit intoJuliaImages:masterfrom
yakir12:yg/clean-corner-detection
Jan 11, 2025
Merged

improve the parse_corners_file function#55
timholy merged 1 commit intoJuliaImages:masterfrom
yakir12:yg/clean-corner-detection

Conversation

@yakir12
Copy link
Collaborator

@yakir12 yakir12 commented Jan 11, 2025

I applied your suggestions for the parse_corners_file function (readline and single character quotation) in the corner detection file as well.

@codecov
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.75%. Comparing base (2506aac) to head (6a7fe2c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   18.75%   18.75%           
=======================================
  Files           3        3           
  Lines          32       32           
=======================================
  Hits            6        6           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timholy timholy merged commit ccb7a06 into JuliaImages:master Jan 11, 2025
9 checks passed
@yakir12 yakir12 deleted the yg/clean-corner-detection branch January 11, 2025 11:34
@ViralBShah
Copy link
Member

@yakir12 If you have some bandwidth to help maintain this package, I can give you commit access.

@yakir12
Copy link
Collaborator Author

yakir12 commented Feb 25, 2025

If it will help relief some pressure then I'll gladly accept.

@ViralBShah
Copy link
Member

Sent you an invite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants