Skip to content

add camera calibration test#54

Merged
timholy merged 2 commits intoJuliaImages:masterfrom
yakir12:yg/test-calibration
Jan 11, 2025
Merged

add camera calibration test#54
timholy merged 2 commits intoJuliaImages:masterfrom
yakir12:yg/test-calibration

Conversation

@yakir12
Copy link
Collaborator

@yakir12 yakir12 commented Jan 9, 2025

Tests camera calibration:

  1. the RMS is lower than 1
  2. the input arguments are correctly mutated as expected

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also need to add this file to runtests.jl?

@codecov
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.75%. Comparing base (2506aac) to head (c0370a8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   18.75%   18.75%           
=======================================
  Files           3        3           
  Lines          32       32           
=======================================
  Hits            6        6           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timholy timholy merged commit beb8c44 into JuliaImages:master Jan 11, 2025
9 checks passed
@yakir12 yakir12 deleted the yg/test-calibration branch January 11, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants