add tests for chessboard corner detection#52
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 18.75% 18.75%
=======================================
Files 3 3
Lines 32 32
=======================================
Hits 6 6
Misses 26 26 ☔ View full report in Codecov by Sentry. |
|
Super weird. I noticed that just |
|
(@timholy, you asked me to ping you directly) |
timholy
left a comment
There was a problem hiding this comment.
Thanks for the PR! It mostly looks good. I've left a few code comments, but one overall comment:
together with the maintainers of this repo
This repo has no maintainers. There are people like me who have merge privileges via JuliaImages, but I don't know or use OpenCV. It would be great if this package got a real maintainer.
I don't know how to fix the "must be initialized" bug, sadly.
Co-authored-by: Tim Holy <tim.holy@gmail.com>
|
I agree and understand. I'm not even sure there's any need to know much about OpenCV to fix this. As I've noticed elsewhere, |
|
Thanks for the contribution! |
This is my first PR in hopes to add a full test-suit for the opencv camera calibration functions. My secret motive is that I've found that
OpenCV.calibrateCamerarandomly fails (i.e. return nonsensical values), and I hope to unearth the issue together with the maintainers of this repo.