reexport ImageQualityIndexes #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #873 +/- ##
=========================================
Coverage ? 76.51%
=========================================
Files ? 9
Lines ? 724
Branches ? 0
=========================================
Hits ? 554
Misses ? 170
Partials ? 0
Continue to review full report at Codecov.
|
|
rebase and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #811
This is not the perfect solution because it uses the same name with
StatsBase.psnr, but it's the simplest one :P Bumped a minor version for safety and hope nobody's usingStatsBase.psnrtogether withImages...Another choice is to extend StatsBase's implementation, then I'll need to add it as a dependency of ImageQualityIndexes. However, in
Images.jlthere's a comment to remove it as a dependency...Images.jl/src/Images.jl
Line 41 in d8ea4d7