Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant show that causes eventloop to remain active #259

Closed

Conversation

IanButterworth
Copy link
Member

Opening this to remind myself.

If JuliaGraphics/Gtk.jl#607 lands, removing this show will mean the Gtk event loop goes to sleep when windows are closed.

With and without that line tests pass locally and I can't tell a functional difference, though I'm not sure I know what to look for.
I suspect it's redundant as the widget gets shown by another showall etc.

I also moved over to the new test/Project.toml format given the lowest julia version supported is 1.6

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #259 (8a0451a) into master (23c3808) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   66.94%   66.91%   -0.04%     
==========================================
  Files           7        7              
  Lines         944      943       -1     
==========================================
- Hits          632      631       -1     
  Misses        312      312              
Impacted Files Coverage Δ
src/ImageView.jl 89.15% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c3808...8a0451a. Read the comment docs.

@IanButterworth
Copy link
Member Author

Fixed upstream. See JuliaGraphics/Gtk.jl#607 (comment)

@IanButterworth IanButterworth deleted the ib/sleep_fix branch January 14, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant