Remove redundant show that causes eventloop to remain active #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this to remind myself.
If JuliaGraphics/Gtk.jl#607 lands, removing this show will mean the Gtk event loop goes to sleep when windows are closed.
With and without that line tests pass locally and I can't tell a functional difference, though I'm not sure I know what to look for.
I suspect it's redundant as the widget gets shown by another
showall
etc.I also moved over to the new
test/Project.toml
format given the lowest julia version supported is 1.6