Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Symbol keys #58

Merged
merged 13 commits into from
Jan 3, 2020
Merged

Switch to Symbol keys #58

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9958543
Switch to `Symbol` keys
Tokazama Dec 18, 2019
4d838ed
Tests don't use deprecated code and ImageMeta fields not accessed
Dec 18, 2019
e21520d
All in on properties instead of keys/getindex for user interface
Dec 19, 2019
bf7d360
Fixed mistakes in deprecations
Dec 19, 2019
500dfa7
Deprecated functionalities should work and be tested now
Dec 19, 2019
217a1ef
Add < v"1.2" support
Tokazama Dec 19, 2019
0900037
Change deprecation for `img.data` and img.properties`
Dec 20, 2019
c95849b
Fixed vestigial space from search and replace
Jan 1, 2020
5b18808
No more mutable ImageMeta
Jan 1, 2020
68cc29c
`data` -> `arraydata`
Jan 1, 2020
ce66520
Deprecation for `data`
Jan 1, 2020
fb834ed
Get rid of inner constructor
Jan 1, 2020
f371dd9
Added deprecation warnings to setproperty!
Jan 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deprecation for data
  • Loading branch information
Zachary Christensen authored and Zachary Christensen committed Jan 1, 2020
commit ce665208739bf35d9ce930d728d06f197057df76
2 changes: 2 additions & 0 deletions src/deprecations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ import Base: getindex, setindex!, delete!, haskey, get, copy!, getproperty, setp
@deprecate(setindex!(img::ImageMeta, X, propname::AbstractString),
setproperty!(img, Symbol(propname), X))

@deprecate(data(img::ImageMeta), arraydata(img))

function to_dict(dold::AbstractDict{String})
dnew = Dict{Symbol,Any}()
for (k, v) in dold
Expand Down