Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests and eliminate depwarns #104

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Fix broken tests and eliminate depwarns #104

merged 1 commit into from
Jul 22, 2023

Conversation

timholy
Copy link
Member

@timholy timholy commented Jul 22, 2023

The deprecation warnings (which are not shown unless you run with Pkg.test) made the package dreadfully slow, so these needed fixing.

CC @ashwani-rathee

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (1bc7795) 98.37% compared to head (1bf507d) 98.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   98.37%   98.40%   +0.03%     
==========================================
  Files          11       11              
  Lines         799      817      +18     
==========================================
+ Hits          786      804      +18     
  Misses         13       13              
Impacted Files Coverage Δ
src/ImageFeatures.jl 100.00% <ø> (ø)
src/brisk.jl 100.00% <100.00%> (ø)
src/core.jl 100.00% <100.00%> (ø)
src/corner.jl 100.00% <100.00%> (ø)
src/freak.jl 98.73% <100.00%> (ø)
src/glcm.jl 100.00% <100.00%> (ø)
src/lbp.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy timholy merged commit 2153078 into master Jul 22, 2023
9 checks passed
@timholy timholy deleted the teh/depwarns branch July 22, 2023 12:55
@timholy timholy mentioned this pull request Aug 2, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant