Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify vessel generator #12

Merged
merged 12 commits into from
Mar 7, 2024
Merged

Modify vessel generator #12

merged 12 commits into from
Mar 7, 2024

Conversation

pauljuerss
Copy link
Collaborator

@pauljuerss pauljuerss commented Feb 28, 2024

The vessel phantom generator has been modified to make it much easier to find parameters for good-looking phantoms.

Notable changes

  • add keyword arguments for parameters that were previously inaccessible
  • the generated route of vessels is now independent of the size of the volume
  • introduce minimum splitting angle to reduce vessel overlap after splitting
  • add parameter max_number_splits to limit the number of splits
  • separate function body of vesselPath into different functions
  • smooth final phantom
  • add 2D support

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (90d0192) to head (9f8a86b).

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #12      +/-   ##
===========================================
+ Coverage   98.79%   100.00%   +1.20%     
===========================================
  Files           3         3              
  Lines          83        91       +8     
===========================================
+ Hits           82        91       +9     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pauljuerss pauljuerss marked this pull request as ready for review February 28, 2024 13:46
@pauljuerss pauljuerss merged commit 99ff7c4 into main Mar 7, 2024
6 checks passed
@pauljuerss pauljuerss deleted the pj/vesselPhantoms branch March 8, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant