Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cube (cuboid), remove MIRT dependence in docs #25

Merged
merged 11 commits into from
Jul 9, 2022
Merged

Add cube (cuboid), remove MIRT dependence in docs #25

merged 11 commits into from
Jul 9, 2022

Conversation

JeffFessler
Copy link
Member

@JeffFessler JeffFessler commented Mar 9, 2022

Support Cuboid shape.
Update LazyGrids compat to 0.4 to ensure proper handling of StepRangeLen.
Also modifies the MRI sense example to use a simple wire response (ala birdcage coil)
instead of the more complicated coil loops from MIRT, to help the docs compile.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #25 (bd1a0a1) into main (8378cae) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        14    +1     
  Lines          439       487   +48     
=========================================
+ Hits           439       487   +48     
Impacted Files Coverage Δ
src/ellipsoid.jl 100.00% <ø> (ø)
src/cuboid.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8378cae...bd1a0a1. Read the comment docs.

@JeffFessler JeffFessler changed the title Add cube (cuboid) Add cube (cuboid), remove MIRT dependence in documentation Jul 8, 2022
@JeffFessler JeffFessler changed the title Add cube (cuboid), remove MIRT dependence in documentation Add cube (cuboid), remove MIRT dependence in docs Jul 8, 2022
@JeffFessler JeffFessler marked this pull request as ready for review July 9, 2022 02:06
@JeffFessler JeffFessler merged commit e6dfe52 into main Jul 9, 2022
@JeffFessler JeffFessler deleted the cube branch July 9, 2022 02:11
@JeffFessler JeffFessler mentioned this pull request Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant