Skip to content

Zstd: Don't persist the checksum param if false #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

Zstd: Don't persist the checksum param if false #195

merged 1 commit into from
Jun 4, 2025

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Jun 4, 2025

Applies the fix in zarr-developers/zarr-python#2655 here.

Fixes #193

@nhz2 nhz2 changed the title Don't persist the checksum param if false Don't persist the Zstd codec checksum param if false Jun 4, 2025
@nhz2 nhz2 changed the title Don't persist the Zstd codec checksum param if false Zstd: Don't persist the checksum param if false Jun 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Pull Request Test Coverage Report for Build 15451518849

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 84.259%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Compressors/zstd.jl 3 4 75.0%
Totals Coverage Status
Change from base Build 15432435479: -1.1%
Covered Lines: 910
Relevant Lines: 1080
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15451518849

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 85.33%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Compressors/zstd.jl 3 4 75.0%
Totals Coverage Status
Change from base Build 15432435479: -0.05%
Covered Lines: 919
Relevant Lines: 1077
💛 - Coveralls

mkitti
mkitti approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@mkitti mkitti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you.

@mkitti mkitti merged commit 50e8063 into master Jun 4, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkitti mkitti mkitti approved these changes

Assignees

@mkitti mkitti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zstd codec checksum configuration not recognized by TensorStore for Zarr v2
3 participants
@nhz2 @coveralls @mkitti