Fix H5Oexist test result after HDF5 bugfix #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bugfix in the HDF5 library changed the return value of the H5Oexists(_by_name) API call. In earlier versions of the library, when the ID was a file ID and the object doesn't exist, the call would return FAIL (-1). The correct behavior is to return false (0). This change will appear in the next released version of HDF5, which is planned to be 2.0.0. This change updates the object test to expect FAIL for 1.14.5 and earlier and false for later versions.
|
I'm applying this patch in our CI, so getting this in ASAP isn't critical |
simonbyrne
approved these changes
Oct 24, 2024
simonbyrne
reviewed
Oct 24, 2024
| @@ -16,7 +16,13 @@ using HDF5.API | |||
| h5open(fn, "r") do h5f | |||
| @test API.h5o_exists_by_name(h5f, "data") | |||
| @test API.h5o_exists_by_name(h5f, "lore") | |||
| @test_throws API.H5Error API.h5o_exists_by_name(h5f, "noonian") | |||
| @static if HDF5.API.h5_get_libversion() <= v"1.14.5" | |||
There was a problem hiding this comment.
@derobins Are there no further planned patch releases on 1.14? Would it be safer to use
Suggested change
| @static if HDF5.API.h5_get_libversion() <= v"1.14.5" | |
| @static if HDF5.API.h5_get_libversion() < v"2" |
There was a problem hiding this comment.
If there were another release of 1.14, it would include the H5Oexists bugfix, so >= 1.14.5 is probably safer.
|
Thank you, @derobins . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bugfix in the HDF5 library changed the return value of the H5Oexists(_by_name) API call. In earlier versions of the library, when the ID was a file ID and the object didn't exist, the call would return FAIL (-1). The correct behavior is to return false (0). This change will appear in the next released version of HDF5, which is planned to be 2.0.0.
This change updates the object test to expect FAIL for 1.14.5 and earlier and false for later versions.