Skip to content

Conversation

@nhz2
Copy link
Member

@nhz2 nhz2 commented Aug 26, 2025

With this PR can_concatenate is now a decoder method instead of a Codec method. I think this makes more sense as different decoders may want to handle concatenated compressed data differently, independently of the Codec.

@nhz2 nhz2 marked this pull request as ready for review August 26, 2025 12:49
@nhz2 nhz2 requested a review from Copilot August 26, 2025 12:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the can_concatenate method from being a Codec method to being a decoder (DecodeOptions) method, allowing different decoders to handle concatenated compressed data differently regardless of the codec used.

  • Moved can_concatenate from Codec implementations to their corresponding DecodeOptions implementations
  • Updated all references to call can_concatenate on decoder options instead of codecs
  • Added backward compatibility by making can_concatenate(c::Codec) delegate to can_concatenate(decode_options(c))

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ChunkCodecCore/src/types.jl Updated documentation to reflect can_concatenate as a decoder method
ChunkCodecCore/src/interface.jl Moved can_concatenate definition and added codec delegation
ChunkCodecCore/src/noop.jl Moved can_concatenate from NoopCodec to NoopDecodeOptions
LibZstd/src/decode.jl Added can_concatenate to ZstdDecodeOptions
LibZstd/src/ChunkCodecLibZstd.jl Removed can_concatenate from ZstdCodec
LibZlib/src/decode.jl Added can_concatenate to GzipDecodeOptions and updated usage
LibLz4/src/decode.jl Added can_concatenate to LZ4FrameDecodeOptions
LibLz4/src/ChunkCodecLibLz4.jl Removed can_concatenate from LZ4FrameCodec
LibBzip2/src/decode.jl Added can_concatenate to BZ2DecodeOptions
LibBzip2/src/ChunkCodecLibBzip2.jl Removed can_concatenate from BZ2Codec
ChunkCodecTests/src/ChunkCodecTests.jl Updated tests to check can_concatenate on decoder options
Multiple CHANGELOG.md files Updated to reference both PR #72 and #73

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.11%. Comparing base (a56fccb) to head (a3eab48).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          38       38           
  Lines        1902     1904    +2     
=======================================
+ Hits         1809     1811    +2     
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nhz2 nhz2 merged commit 503e154 into main Aug 26, 2025
63 checks passed
@nhz2 nhz2 deleted the nz/can_concatenate-decoder branch August 26, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants