Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log at LogLevel(-1_000) #155

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Log at LogLevel(-1_000) #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/requests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ See also [`request_json`](@ref) and [`request_raw`](@ref).
#
# Ref: https://docs.julialang.org/en/v1/stdlib/Logging

@logmsg LogLevel(-3_000) "FHIRClient.request()" path verb tryparse_json(response_body)
@logmsg LogLevel(-1_000) "FHIRClient.request()" path verb tryparse_json(response_body)

response_object = JSON3.read(response_body, T; kwargs...)::T
return response_object
Expand Down
2 changes: 1 addition & 1 deletion src/tryparse.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# `response_body` so that the user can try to figure out why it failed to
# parse as valid JSON.
bt = catch_backtrace()
@logmsg LogLevel(-3_000) "tryparse_json()" exception = (ex, bt) response_body
@logmsg LogLevel(-1_000) "tryparse_json()" exception = (ex, bt) response_body

Check warning on line 11 in src/tryparse.jl

View check run for this annotation

Codecov / codecov/patch

src/tryparse.jl#L11 

Added line #L11 was not covered by tests
nothing
end
return response_json
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import URIs
# Also possibly related: https://github.com/JuliaLang/julia/issues/34037
#
# Note: this is a GLOBAL setting:
Logging.disable_logging(Logging.BelowMinLevel)
# Logging.disable_logging(Logging.BelowMinLevel)

@testset "FHIRClient.jl" begin
# When we run the tests, we want to make sure that none of the `@logmsg`
Expand Down
Loading