Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public fire.ly server in tests #135

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Use public fire.ly server in tests #135

merged 1 commit into from
Nov 26, 2023

Conversation

devmotion
Copy link
Member

This PR fixes the (probably temporary) test errors caused by the HAPI FHIR server errors by switching to the public fire.ly server in our tests.

Fixes #134.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f2b171) 100.00% compared to head (ab27918) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          187       187           
=========================================
  Hits           187       187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DilumAluthge
Copy link
Member

I wonder if this is a good time to refactor our test suite and factor all of the test-server-specific values out.

So e.g. we could define a struct inside of test/runtests.jl of the form:

Base.@kwdef struct TestFHIRServer
    base_url::String
    patient_firstname::String
    ...
end

Then, the other parts of the test suite will just extract the values from the TestFHIRServer struct.

And then, in order to switch test servers, we only need to change the values in one place.

@devmotion
Copy link
Member Author

I'm not sure if it's worth it since we only use the server in two places. Additionally, I thought about using a different query for testing pagination - for the current tests, I looked up a query that returned only very few results, all with a proper ID, but for pagination tests many search results would be desirable.

@DilumAluthge
Copy link
Member

I'll just put it into an issue for now: #136

@devmotion devmotion merged commit 185733f into master Nov 26, 2023
15 checks passed
@devmotion devmotion deleted the dw/firely branch November 26, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail due to error of HAPI FHIR test server
2 participants