Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support GtkSizeGroup and add tests #53

Merged
merged 4 commits into from
Feb 17, 2024
Merged

support GtkSizeGroup and add tests #53

merged 4 commits into from
Feb 17, 2024

Conversation

jwahlstrand
Copy link
Member

@jwahlstrand jwahlstrand commented Feb 17, 2024

Add push! and delete! methods for GtkSizeGroup and tests for a method that returns a GList with transfer=none.

Also put a limit on the version of libpng, which prevents tests from failing on Windows x86. I assume this is a bug in one of the libraries and will look into it further later.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d94555e) 84.13% compared to head (bcfc8cd) 84.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   84.13%   84.14%           
=======================================
  Files          44       44           
  Lines        4716     4718    +2     
=======================================
+ Hits         3968     3970    +2     
  Misses        748      748           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwahlstrand jwahlstrand changed the title investigate CI failures on Windows, 32 bit support GtkSizeGroup and add tests Feb 17, 2024
@jwahlstrand jwahlstrand merged commit 8198d3f into main Feb 17, 2024
11 checks passed
@jwahlstrand jwahlstrand deleted the jw/investigate branch March 3, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants