Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameters argument for GSimpleAction, add_action, add_stateful_action #51

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

jwahlstrand
Copy link
Member

@jwahlstrand jwahlstrand commented Jan 28, 2024

Make it possible to set parameters when creating stateful actions and more convenient in other cases. Also adds support for tuples in GVariant.

Fixes #50

Thanks @hja3

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2c7132c) 85.75% compared to head (7f6a8a8) 85.71%.

Files Patch % Lines
src/GLib/actions.jl 82.60% 4 Missing ⚠️
src/GLib/gvariant.jl 89.28% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   85.75%   85.71%   -0.05%     
==========================================
  Files          44       44              
  Lines        4668     4689      +21     
==========================================
+ Hits         4003     4019      +16     
- Misses        665      670       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwahlstrand jwahlstrand merged commit d9771de into main Jan 29, 2024
11 checks passed
@jwahlstrand jwahlstrand deleted the jw/action-pars branch February 12, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stateful action with parameter
2 participants