Skip to content

Conversation

@bin-wang
Copy link
Contributor

Currently, the documentation states that an error will be thrown if edges are added using nonexistent labels, which is not true. The actual behavior is that it will just fail silently: the edge will not be added, and no error will be thrown.

Frankly, I think this behavior is very unintuitive and should be subject to change. In networkx, the nodes will be automatically added. At least we should update the documentation for now.

Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I have opened #80 to keep track

@gdalle gdalle merged commit d59401c into JuliaGraphs:master Jul 18, 2024
@bin-wang bin-wang deleted the patch-1 branch July 18, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants