Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minimum Julia version v1.6 #91

Merged

Conversation

simonschoelly
Copy link
Contributor

This PR makes Julia v1.6 the minimum required version for Graphs.jl.

I also would bump the version of this package to v1.6, so that we could still back port fixes for older Julia versions into the Graphs.jl v1.5.x space, and because it is just nice that the version of Julia then aligns with the of Graphs.jl

If any downstream package has some issues with that, please raise your objections here, but in any case, it should still be possible for you to use Graphs.jl at version v1.5.1.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #91 (92131de) into master (bf9544b) will increase coverage by 0.30%.
The diff coverage is n/a.

❗ Current head 92131de differs from pull request most recent head e55f1d3. Consider uploading reports for the commit e55f1d3 to get more accurate results

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   97.48%   97.78%   +0.30%     
==========================================
  Files         109      107       -2     
  Lines        6318     6194     -124     
==========================================
- Hits         6159     6057     -102     
+ Misses        159      137      -22     

@mschauer
Copy link
Contributor

Not doubting it, but can you say the rationale why 1.6?

@etiennedeg
Copy link
Member

1.6 is LTS (see discussion on Slack#graphs)

@simonschoelly simonschoelly added the do not merge Do not merge this PR (yet) label Jan 11, 2022
@simonschoelly simonschoelly self-assigned this Jan 15, 2022
@simonschoelly
Copy link
Contributor Author

Thanks for approving, as there was no resistance I think this is indeed the way go go.

Currently I would like to get as many bug fixes as possible in Graphs.jl, then tag a final 1.5.2 version that still works with older Julia versions, and then merge in this PR.

@ViralBShah
Copy link
Contributor

ViralBShah commented Jan 29, 2022

I'll reiterate some of the reasons from slack (from memory):

  1. 1.6 is the new LTS.
  2. Lots of threading related fixes from 1.3 to 1.6 and we want to use that as the baseline for new features.
  3. It is best not to spend limited developer bandwidth on backporting to old versions of Julia.

@simonschoelly simonschoelly merged commit c11e60b into JuliaGraphs:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this PR (yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants