-
Notifications
You must be signed in to change notification settings - Fork 102
use /test/Project.toml instead of [extras] in /Project.toml #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
in #433 the concern of having Formatter for more than just tests was raised, e.g. if Formatter is used in a pre-commit hook: that is fine, as either way Formatter should not be a dependency of Graphs, rather just another package in the dev environment in which Graphs is already dev-ed (or in the root environment). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 120 120
Lines 6953 6953
=======================================
Hits 6773 6773
Misses 180 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benchmark/Manifest.toml | ||
.benchmarkci | ||
*.cov | ||
/Manifest.toml | ||
/docs/Manifest.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this means no Manifest.toml would get added to git?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
I have some issues running the tests locally now - can you try if it works for you? I create open Julia v1.12 with a new temporary project:
|
The following worked for me (maybe the difference is using
|
This PR simplifies the Project.toml file by splitting off the test dependencies in a separate PR.
The main value of doing so is avoiding annoying compat bounds on test dependencies that leads to Graphs downgrading other packages on a user's system.
Before this PR the following was not possible
] add Graphs JuliaFormatter@2
because our tests had a dependencies on JuliaFormatter==1. Now that the test environment is separate this is not an issue.Alternative to #433 and #435 that does not require changing anything about our formatting. Of course, switching to JuliaFormatter 2 would be nice at some point, but the urgency is to make sure that our package is not downgrading other people's environments.