[Port] fix possible NaN in closeness centrality. Closes #1555 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage 99.45% 99.46%
=======================================
Files 106 106
Lines 5554 5556 +2
=======================================
+ Hits 5524 5526 +2
Misses 30 30 |
|
Seems like tests that otherwise don't fail have failed on windows (but no elsewhere). Can you review the Windows failure and see if this is ok? |
|
@etienneINSA I have invited you to the JuliaGraphs org, and to have write access to this repo. Since you have a number of open PRs, I think the project could benefit from your contributions - and hopefully write access helps making it a bit easier. |
|
Thanks @ViralBShah for the invitation, I hope I can bring a modest help to this project. @jpfairbanks This PR makes some tests fail on windows-latest. Why was it merged ? Is it confirmed that the failed tests are not caused by this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #1568