Use GenericGraph for testing shortestpaths algorithms #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 114 114
Lines 6658 6660 +2
=======================================
+ Hits 6471 6473 +2
Misses 187 187 |
12 tasks
gdalle
approved these changes
Jul 5, 2023
jwassmer
pushed a commit
to jwassmer/Graphs.jl
that referenced
this pull request
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the tests for the shortestpath algorithm use
GenericGraphThe function in
src/shortestpaths/yen.jldoes currently not work with GenericGraph yet. Alsoa_staronly kind of works withGenericGraphas this function by default takesedgetype(g)as an argument and then tries to use that type as an edge constructor. This does work forGenericEdgethough. So I doubled some tests - some are run withSimpleGraphandSimpleDiGraphand some are run withGenericGraphandGenericDiGraph, but the default edgetype is replaced bySimpleEdge.In addition, this PR fixes a bug where the
has_negative_edge_cyclemight not only fail on a generic graph, but return an incorrect result, as theMethodErrorexception was silently caught and ignored.