Test cycles with generic graph #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
+ Coverage 97.19% 97.20% +0.01%
==========================================
Files 114 114
Lines 6658 6658
==========================================
+ Hits 6471 6472 +1
+ Misses 187 186 -1 |
|
Partial solution to #224 |
simonschoelly
force-pushed
the
test-cycles-with-generic-graph
branch
from
2c597a5
to
8aad8dc
Compare
12 tasks
This was referenced Jul 5, 2023
gdalle
approved these changes
Jul 5, 2023
jwassmer
pushed a commit
to jwassmer/Graphs.jl
that referenced
this pull request
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the tests for the cycles algorithm use
GenericGraphCurrently the algorithms in
src/cycles/incremental.jlandsrc/cycles/johnson.jldo not work with generic graphs - this is, because they relay on modifying graph functions. At least for johnson this might be fixable but for incremental it seems to be necessary to have modifiable graphs.In addition, this PR changes the function
cycle_basisso that it accepts an arbitraryAbstractGraphinstead of just anAbstractSimpleGraph.