Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two sided dijkstra #268

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Graphs.jl
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ export
transitivereduction,
yen_k_shortest_paths,
desopo_pape_shortest_paths,
bidijkstra_shortest_path,

# centrality
betweenness_centrality,
Expand Down
163 changes: 135 additions & 28 deletions src/shortestpaths/dijkstra.jl
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function dijkstra_shortest_paths(
parents = zeros(U, nvg)
visited = zeros(Bool, nvg)

pathcounts = zeros(nvg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should not change this, it might overflow.

pathcounts = zeros(Int, nvg)
preds = fill(Vector{U}(), nvg)
H = PriorityQueue{U,T}()
# fill creates only one array.
Expand All @@ -110,33 +110,11 @@ function dijkstra_shortest_paths(
alt = d + distmx[u, v]

alt > maxdist && continue

if !visited[v]
visited[v] = true
dists[v] = alt
parents[v] = u

pathcounts[v] += pathcounts[u]
if allpaths
preds[v] = [u;]
end
H[v] = alt
elseif alt < dists[v]
dists[v] = alt
parents[v] = u
#615
pathcounts[v] = pathcounts[u]
if allpaths
resize!(preds[v], 1)
preds[v][1] = u
end
H[v] = alt
elseif alt == dists[v]
pathcounts[v] += pathcounts[u]
if allpaths
push!(preds[v], u)
end
end
relax(u,v,distmx,dists,parents,visited,H;
allpaths=allpaths,
pathcounts=pathcounts,
preds=preds
)
end
end

Expand Down Expand Up @@ -169,3 +147,132 @@ function dijkstra_shortest_paths(
g, [src;], distmx; allpaths=allpaths, trackvertices=trackvertices, maxdist=maxdist
)
end

function relax(u,
v,
distmx::AbstractMatrix{T},
dists::Vector{T},
parents::Vector{U},
visited::Vector{Bool},
Q::PriorityQueue{U,T};
allpaths=false,
pathcounts=nothing,
preds=nothing,
forward=true
) where {T<:Real} where {U<:Integer}
alt = dists[u] + (forward ? distmx[u, v] : distmx[v, u])

if !visited[v]
visited[v] = true
dists[v] = alt
parents[v] = u

if !isnothing(pathcounts)
pathcounts[v] += pathcounts[u]
end
if allpaths
preds[v] = [u;]
end
Q[v] = alt
elseif alt < dists[v]
dists[v] = alt
parents[v] = u
#615
if !isnothing(pathcounts)
pathcounts[v] = pathcounts[u]
end
if allpaths
resize!(preds[v], 1)
preds[v][1] = u
end
Q[v] = alt
elseif alt == dists[v]
if !isnothing(pathcounts)
pathcounts[v] += pathcounts[u]
end
if allpaths
push!(preds[v], u)
end
end
end

"""
bidijkstra_shortest_paths(g, src, dst, distmx=weights(g));

Perform [Bidirectional Dijkstra's algorithm](https://www.homepages.ucl.ac.uk/~ucahmto/math/2020/05/30/bidirectional-dijkstra.html)
on a graph, computing the shortest path between `src` and `dst`.

# Examples
```jldoctest
julia> using Graphs

julia> bidijkstra_shortest_path(cycle_graph(5), 1, 4)
3-element Vector{Int64}:
1
5
4

julia> bidijkstra_shortest_path(path_graph(5), 1, 4)
4-element Vector{Int64}:
1
2
3
4
```
"""
function bidijkstra_shortest_path(
g::AbstractGraph,
src::U,
dst::U,
distmx::AbstractMatrix{T}=weights(g)
) where {T<:Real} where {U<:Integer}
if src == dst
return Int[]
end
# keep weight of the best seen path and the midpoint vertex
μ, mid_v = typemax(T), -1
nvg = nv(g)
dists_f, dists_b= fill(typemax(T), nvg), fill(typemax(T), nvg)
parents_f, parents_b= zeros(U, nvg), zeros(U, nvg)
visited_f, visited_b = zeros(Bool, nvg),zeros(Bool, nvg)
preds_f, preds_b = fill(Vector{U}(), nvg), fill(Vector{U}(), nvg)
Qf, Qb = PriorityQueue{U,T}(), PriorityQueue{U,T}()

dists_f[src], dists_b[dst]= zero(T), zero(T)
visited_f[src], visited_b[dst]= true, true
Qf[src], Qb[dst] = zero(T), zero(T)

while !isempty(Qf) && !isempty(Qb)
uf, ub = dequeue!(Qf), dequeue!(Qb)

for v in outneighbors(g, uf)
relax(uf, v, distmx, dists_f, parents_f, visited_f, Qf)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relax function clarifies things, would it be hard to add it to the original dijkstra too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping you would notice =p I'll make the changes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a new version of the relax function that should work for both the dijkstra_shortest_paths and bidijkstra_shortest_path but it is a bit clunky. I am wondering; why the need for the parents and preds structures ? wouldn't the list of predecessors be enough ?
A cosmetic note: should we rename the function the bidijkstra_shortest_paths if it should be able to deal with multiple paths ?

if visited_b[v] && (dists_f[uf]+distmx[uf,v]+dists_b[v]) < μ
# we have found an edge between the forward and backward exploration
μ = dists_f[uf]+distmx[uf,v]+dists_b[v]
mid_v = v
end
end

for v in inneighbors(g, ub)
relax(ub, v, distmx, dists_b, parents_b, visited_b, Qb; forward=false)
if visited_f[v] && (dists_f[v]+distmx[v,ub]+dists_b[ub]) < μ
# we have found an edge between the forward and backward exploration
μ = dists_f[v]+distmx[v,ub]+dists_b[ub]
mid_v = v
end
end
if dists_f[uf]+dists_b[ub] >= μ
break
end
end
if mid_v == -1
# no path exists between source and destination
return Int[]
end
ds_f = DijkstraState{T,U}(parents_f, dists_f, preds_f, zeros(nvg), Vector{U}())
ds_b = DijkstraState{T,U}(parents_b, dists_b, preds_b, zeros(nvg), Vector{U}())
path = vcat(enumerate_paths(ds_f, mid_v), reverse(enumerate_paths(ds_b, mid_v)[1:end-1]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there are several paths?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to deal with such situations, as far as I can tell multiple paths with the same cost can be detected if the condition mu == ls + lt is reached. I'll look into it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that bidijkstra_shortest_path only returns src-dst-paths it doesn't make much sense to keep a full list of predecessors, does it ? I am not sure what the most elegant way to deal with these situations, especially when trying to share code with dijkstra_shortest_paths.
I've also noticed that there doesn't seem to be a straightforward way to retrieve multiple paths for a single (src,dst) pair. As far a I can tell the enumerate_paths routine returns a single path per destination. Should this be addressed at some point ?

return path
end

1 change: 1 addition & 0 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ tests = [
"shortestpaths/bellman-ford",
"shortestpaths/desopo-pape",
"shortestpaths/dijkstra",
"shortestpaths/bidijkstra",
"shortestpaths/johnson",
"shortestpaths/floyd-warshall",
"shortestpaths/yen",
Expand Down
19 changes: 19 additions & 0 deletions test/shortestpaths/bidijkstra.jl
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
@testset "Bidijkstra" begin
g3 = path_graph(5)
g4 = path_digraph(5)

d1 = float([0 1 2 3 4; 5 0 6 7 8; 9 10 0 11 12; 13 14 15 0 16; 17 18 19 20 0])
d2 = sparse(float([0 1 2 3 4; 5 0 6 7 8; 9 10 0 11 12; 13 14 15 0 16; 17 18 19 20 0]))
for g in testgraphs(g3), dg in testdigraphs(g4)
@test @inferred(bidijkstra_shortest_path(g, 1, 4, d1)) ==
@inferred(bidijkstra_shortest_path(dg, 1, 4, d1)) ==
@inferred(bidijkstra_shortest_path(g, 1, 4, d2))
@test isempty(@inferred(bidijkstra_shortest_path(dg, 4, 1)))
end

# test for #1258
g = complete_graph(4)
w = float([1 1 1 4; 1 1 1 1; 1 1 1 1; 4 1 1 1])
ds = dijkstra_shortest_paths(g, 1, w)
@test length(bidijkstra_shortest_path(g, 1, 4, w)) == 3 # path is a sequence of vertices
end
16 changes: 16 additions & 0 deletions test/shortestpaths/dijkstra.jl
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,20 @@
ds = @inferred(dijkstra_shortest_paths(g, 3, m;maxdist=3.0))
@test ds.dists == [2, 1, 0, Inf, Inf, 3]
end

# bidijkstra_shortest_path
Dolgalad marked this conversation as resolved.
Show resolved Hide resolved
g4 = path_digraph(5)
d1 = float([0 1 2 3 4; 5 0 6 7 8; 9 10 0 11 12; 13 14 15 0 16; 17 18 19 20 0])
d2 = sparse(float([0 1 2 3 4; 5 0 6 7 8; 9 10 0 11 12; 13 14 15 0 16; 17 18 19 20 0]))

for g in testdigraphs(g4)
x = @inferred(dijkstra_shortest_paths(g, 2, d1))
p = enumerate_paths(x, 4)
y = @inferred(bidijkstra_shortest_path(g, 2, 4, d1))
z = @inferred(bidijkstra_shortest_path(g, 2, 4, d2))

@test p == y == z
end


end
Loading