added Graphormer.jl #265
added Graphormer.jl #265
Conversation
|
Is there a contributing guideline doc so I can fix the build tests at least? |
|
test failures is probably related to some changes in dependencies like FiniteDifferences.jl, I'll have to investigate |
src/layers/conv.jl
Outdated
| @@ -1670,3 +1670,67 @@ function Base.show(io::IO, l::TransformerConv) | |||
| (in, ein), out = l.channels | |||
| print(io, "TransformerConv(($in, $ein) => $out, heads=$(l.heads))") | |||
| end | |||
|
|
|||
| struct GraphomerLayer{DX <: Dense, DE <: Union{Dense, Nothing}, T, A <: AbstractMatrix, F, B} <: GNNLayer | |||
There was a problem hiding this comment.
we can start adding a docstring and some tests
|
I think it would be good to add an example to the example folder showing the full pipeline, |
|
Anyways, this looks very good already |
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 81.70% 80.28% -1.43%
==========================================
Files 17 17
Lines 1864 1902 +38
==========================================
+ Hits 1523 1527 +4
- Misses 341 375 +34
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@CarloLucibello where should I add the tests ? Secondly is adding tests here similar too |
|
take a look at the test folder. The entry point is |
|
Hi @CarloLucibello due to some conflicts that I was trying to resolve the PR is closed now. Let me try fix it and raise another PR |
|
Sure, sorry for that, I made some pretty extensive changes |
|
No problem you can have a look on #275 |
fixes #251
To do:
@CarloLucibello is there anything else to work on?