Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we change @emit to @qmlemit? #44

Open
NHDaly opened this issue Jun 26, 2017 · 2 comments
Open

Can we change @emit to @qmlemit? #44

NHDaly opened this issue Jun 26, 2017 · 2 comments

Comments

@NHDaly
Copy link
Contributor

NHDaly commented Jun 26, 2017

To keep in style with the rest of the macros exported by this plugin, can we change @emit to @qmlemit?:
https://github.com/barche/QML.jl/blob/master/src/QML.jl#L119

When I came across that line in your example, I wasn't sure if that was some standard Julia "create an interrupt signal" macro or a QML-specific "signal".


Thanks again for the presentation at JuliaCon! I'm excited by this project!
Appreciate your thoughts!
~Nathan

@barche
Copy link
Collaborator

barche commented Jun 26, 2017

True, that would be more consistent. I did discuss with @shashi about issue #43, so I'm going to take a close look at the Observables package first and see if we can maybe come up with a general signals/slots syntax.

@NHDaly
Copy link
Contributor Author

NHDaly commented Jun 26, 2017 via email

barche added a commit that referenced this issue Sep 1, 2017
barche added a commit that referenced this issue Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants