Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

fail in __init__() with error if Gtk4 was previously imported #651

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

jwahlstrand
Copy link
Contributor

This prevents Julia from crashing.

Also remove redundant tests that I introduced.

…ts a crash)

Also remove redundant tests that I introduced
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2750738869

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.2%) to 62.77%

Files with Coverage Reduction New Missed Lines %
src/GLib/signals.jl 6 63.79%
Totals Coverage Status
Change from base Build 2692998865: -2.2%
Covered Lines: 1659
Relevant Lines: 2643

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 28, 2022

Pull Request Test Coverage Report for Build 2757877506

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+5.3%) to 70.193%

Files with Coverage Reduction New Missed Lines %
src/GLib/signals.jl 6 74.52%
Totals Coverage Status
Change from base Build 2692998865: 5.3%
Covered Lines: 1785
Relevant Lines: 2543

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #651 (2cbd281) into master (b1e2d5e) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   65.80%   65.60%   -0.21%     
==========================================
  Files          32       32              
  Lines        2720     2721       +1     
==========================================
- Hits         1790     1785       -5     
- Misses        930      936       +6     
Impacted Files Coverage Δ
src/Gtk.jl 92.18% <100.00%> (+0.12%) ⬆️
src/GLib/signals.jl 74.18% <0.00%> (-2.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e2d5e...2cbd281. Read the comment docs.

@tknopp tknopp merged commit 4a45ca4 into JuliaGraphics:master Jul 29, 2022
@jwahlstrand jwahlstrand deleted the gtk4check branch July 29, 2022 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants