Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

add more tests, fix a few issues with GList, GtkGrid, GtkNotebook, GtkOverlay #603

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Conversation

jwahlstrand
Copy link
Contributor

Fixes a problem with finalizing GLists, appending GLists, and iterating over GSList. Also fixes a few issues in layout.jl found while adding tests.

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #603 (591c7bf) into master (ce2673a) will increase coverage by 4.93%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   51.86%   56.80%   +4.93%     
==========================================
  Files          32       32              
  Lines        2659     2669      +10     
==========================================
+ Hits         1379     1516     +137     
+ Misses       1280     1153     -127     
Impacted Files Coverage Δ
src/GLib/glist.jl 84.35% <100.00%> (+16.12%) ⬆️
src/layout.jl 77.41% <100.00%> (+50.24%) ⬆️
src/GLib/GLib.jl 77.27% <0.00%> (-4.55%) ⬇️
src/base.jl 75.00% <0.00%> (+3.12%) ⬆️
src/toolbar.jl 90.00% <0.00%> (+10.00%) ⬆️
src/displays.jl 33.15% <0.00%> (+20.10%) ⬆️
src/container.jl 81.39% <0.00%> (+34.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2673a...591c7bf. Read the comment docs.

@tknopp tknopp merged commit ceeb0b1 into JuliaGraphics:master Dec 29, 2021
@jwahlstrand jwahlstrand deleted the testing branch December 29, 2021 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants