Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add environment for generator scripts #555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vexatos
Copy link
Contributor

@Vexatos Vexatos commented Jan 14, 2021

Minimal Project file for the generator scripts. See #535 (comment).

From CI or tests, it'd be called like this:

using Gtk # latest Gtk from dev, imported in the main or test Gtk env
using Pkg
Pkg.activate("$root/gen")
Pkg.instantiate()
include("gtk_auto_gen.jl")

The generator scripts depend on the dev version of Gtk.jl, but actually making the environment depend on it isn't possible without including the Manifest.toml (using repo-url = ".."), which probably shouldn't be done.

@tknopp
Copy link
Collaborator

tknopp commented Jan 14, 2021

But aren't the tests run in dev mode? Not sure how this is accomplished in the test's project file

@Vexatos
Copy link
Contributor Author

Vexatos commented Jan 14, 2021

Testing in julia using Pkg.test() is a kind of special environment, so yes, tests are run using Gtk from the directory, meaning if you were to run the generator script from inside the test environment (not that I'd recommend that) you'd get the correct output. Similarly, you can run it starting from the primary Project.toml in any CI step for the same effect. Gtk.jl doesn't have a separate Project.toml for the tests yet so I think it does that anyway.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #555 (c128488) into master (8742856) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   47.43%   47.52%   +0.08%     
==========================================
  Files          32       32              
  Lines        2382     2382              
==========================================
+ Hits         1130     1132       +2     
+ Misses       1252     1250       -2     
Impacted Files Coverage Δ
src/GLib/signals.jl 73.97% <0.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8742856...c128488. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants