Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix #547 and revert #355 #548

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Fix #547 and revert #355 #548

merged 1 commit into from
Dec 30, 2020

Conversation

tknopp
Copy link
Collaborator

@tknopp tknopp commented Dec 29, 2020

With the new BB binaries the window decorations show correctly without setting GTK_CSD=1

close #547

@ping NeoKat75: I cannot test this, have you tested it with exactly this change?

With the new BB binaries the window decorations show correctly without setting GTK_CSD=1
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #548 (007591d) into master (f879355) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
+ Coverage   49.94%   49.98%   +0.03%     
==========================================
  Files          32       32              
  Lines        2515     2513       -2     
==========================================
  Hits         1256     1256              
+ Misses       1259     1257       -2     
Impacted Files Coverage Δ
src/Gtk.jl 88.46% <ø> (-0.83%) ⬇️
src/GLib/signals.jl 76.05% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f879355...007591d. Read the comment docs.

@NeoKat75
Copy link

@NeoKat75: I cannot test this, have you tested it with exactly this change?

@tknopp yep, it works just fine!

@tknopp tknopp merged commit 8442bfb into master Dec 30, 2020
@tknopp tknopp deleted the tknopp-patch-2 branch December 30, 2020 00:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title bar buttons are now displayed properly on Windows with GTK_CSD=1, #355 should be reversed
2 participants